Compaction overhaul by DOsinga · Pull Request #5186 · block/goose

DOsinga · 2025-10-15T15:31:18Z

No description provided.

…/goose into douwe-dkatz-alexhancock/compaction * 'douwe-dkatz-alexhancock/compaction' of github.com:block/goose: feat: add Daily Standup Report Generator recipe (#5123) (#5131) Sort providers in alphabetical vs random (#5090) Declarative providers (#5084)

…ncock/compaction * 'main' of github.com:block/goose: Fix provider sort (#5188) blog: Getting Started with Goose on Windows (#5156) feat: add CI/CD Pipeline recipe (#5183)

jamadeo

all of the smaller comments I'll put up a follow-up for. But the one about saving the new compacted conversation on user request seems maybe important?

jamadeo · 2025-10-15T19:28:41Z

crates/goose/src/agents/subagent_handler.rs

+                Ok(AgentEvent::McpNotification(_)) | Ok(AgentEvent::ModelChange { .. }) => {}
+                Ok(AgentEvent::HistoryReplaced(updated_conversation)) => {
+                    conversation = updated_conversation;
+                }


does this mean sub-agents never compacted?

jamadeo · 2025-10-15T19:30:44Z

crates/goose/src/context_mgmt/mod.rs

+    preserve_last_user_message: bool,
+    threshold_override: Option<f64>,
+    session_metadata: Option<&crate::session::Session>,
+) -> std::result::Result<(bool, Conversation, Vec<usize>, Option<ProviderUsage>), anyhow::Error> {


should this return AutoCompactionResult?

jamadeo · 2025-10-15T19:31:30Z

crates/goose/src/context_mgmt/mod.rs

+        .await
+        .map_err(|e| anyhow::anyhow!("Failed to ensure usage tokens: {}", e))?;
+
+    std::prelude::rust_2015::Ok(Some((response, provider_usage)))


strange qualifier here

jamadeo · 2025-10-15T19:54:49Z

crates/goose-server/src/routes/context.rs

+    )
+    .await
+    .map_err(|_| StatusCode::INTERNAL_SERVER_ERROR)?;
+    // TODO(Douwe): store into db


this seems important! I guess right now the new conversation will be on the client, and then on the next message we'll do the replacement in the agent reply handler?

yes, that's how it works. we'll probably print a warning in the reply that the format is unexpected and then go on.

…/goose into douwe-dkatz-alexhancock/compaction * 'douwe-dkatz-alexhancock/compaction' of github.com:block/goose: fix: tests related to message metadata

* main: Compaction overhaul (block#5186) fix: block#3960 better approach to input schema for dynamic task params (block#5189) used recipe id or deeplink to start agent (block#5154)

* main: Skip hidden & real format (#5194) docs: Hacktoberfest blog submission - Best Practices for Using Goose in Enterprise Environments by Anudhyan Datta. (#5184) docs: prompt injection detection (#5193) Fix mcp large response race condition (#5065) Compaction overhaul (#5186) fix: #3960 better approach to input schema for dynamic task params (#5189) used recipe id or deeplink to start agent (#5154) [docs] Add Blog Post: "Designing AI for Users, Not Just LLMs" (#5190) docs: update cognee, jetbrains, mbot extensions config (#5172) Minimally disable subagents when not in autonomous model (#5149) Fix provider sort (#5188) blog: Getting Started with Goose on Windows (#5156) feat: add CI/CD Pipeline recipe (#5183) feat: add Daily Standup Report Generator recipe (#5123) (#5131) Sort providers in alphabetical vs random (#5090) Declarative providers (#5084) adding youtube link to firecrawl mcp tutorial, merge after 9am Eastern Oct 15 (#5173) Ollama integration: modified default model + added models (#5153) Fix codex subagent configuration in documentation (#5180)

* main: (119 commits) Break compaction back into check_ and do_ compaction (#5212) fix: revert built app name to uppercase Goose (#5206) feat: add Code Documentation Generator recipe (#5121) (#5125) Revert "feat: enhance goose to search sessions for easy recall (#5177)" (#5209) Blog: Best Practices for Prompt Engineering with goose (#5204) force WAL sync after session create (#5202) Feat: goose Apify MCP integration docs (#5047) feat: enhance goose to search sessions for easy recall (#5177) Skip hidden & real format (#5194) docs: Hacktoberfest blog submission - Best Practices for Using Goose in Enterprise Environments by Anudhyan Datta. (#5184) docs: prompt injection detection (#5193) Fix mcp large response race condition (#5065) Compaction overhaul (#5186) fix: #3960 better approach to input schema for dynamic task params (#5189) used recipe id or deeplink to start agent (#5154) [docs] Add Blog Post: "Designing AI for Users, Not Just LLMs" (#5190) docs: update cognee, jetbrains, mbot extensions config (#5172) Minimally disable subagents when not in autonomous model (#5149) Fix provider sort (#5188) blog: Getting Started with Goose on Windows (#5156) ...

* main: (143 commits) Break compaction back into check_ and do_ compaction (#5212) fix: revert built app name to uppercase Goose (#5206) feat: add Code Documentation Generator recipe (#5121) (#5125) Revert "feat: enhance goose to search sessions for easy recall (#5177)" (#5209) Blog: Best Practices for Prompt Engineering with goose (#5204) force WAL sync after session create (#5202) Feat: goose Apify MCP integration docs (#5047) feat: enhance goose to search sessions for easy recall (#5177) Skip hidden & real format (#5194) docs: Hacktoberfest blog submission - Best Practices for Using Goose in Enterprise Environments by Anudhyan Datta. (#5184) docs: prompt injection detection (#5193) Fix mcp large response race condition (#5065) Compaction overhaul (#5186) fix: #3960 better approach to input schema for dynamic task params (#5189) used recipe id or deeplink to start agent (#5154) [docs] Add Blog Post: "Designing AI for Users, Not Just LLMs" (#5190) docs: update cognee, jetbrains, mbot extensions config (#5172) Minimally disable subagents when not in autonomous model (#5149) Fix provider sort (#5188) blog: Getting Started with Goose on Windows (#5156) ...

* 'main' of github.com:block/goose: (22 commits) Rewrite extension management tools (#5057) fix: re-sync package-lock.json (#5235) docs: Hacktoberfest MCP youtube short entry to community-content.json (#5150) feat: add schedule button to recipe entries (#5217) Autocompact threshold UI cleanup (#5232) fix: correct schema for openai tools (#5229) Break compaction back into check_ and do_ compaction (#5212) fix: revert built app name to uppercase Goose (#5206) feat: add Code Documentation Generator recipe (#5121) (#5125) Revert "feat: enhance goose to search sessions for easy recall (#5177)" (#5209) Blog: Best Practices for Prompt Engineering with goose (#5204) force WAL sync after session create (#5202) Feat: goose Apify MCP integration docs (#5047) feat: enhance goose to search sessions for easy recall (#5177) Skip hidden & real format (#5194) docs: Hacktoberfest blog submission - Best Practices for Using Goose in Enterprise Environments by Anudhyan Datta. (#5184) docs: prompt injection detection (#5193) Fix mcp large response race condition (#5065) Compaction overhaul (#5186) fix: #3960 better approach to input schema for dynamic task params (#5189) ...

Douwe Osinga and others added 16 commits October 15, 2025 09:30

First

3d4f5db

fix session metadata tracking

9eeb8c9

continued compaction shaving

5c0b191

finish deletion of maybe_compact

5403fb7

boolean if compacted

a0b4f1f

Rm extra params

7f9d599

simplify context_mgmt crate

0ccecae

delete more things

7888013

async is default

33cebea

Merge branch 'main' into douwe-dkatz-alexhancock/compaction

2b1ab1b

Stream fix and force compact

52c41d3

Merge branch 'main' of github.com:block/goose into douwe-dkatz-alexha…

e31b8ad

…ncock/compaction * 'main' of github.com:block/goose: Fix provider sort (#5188) blog: Getting Started with Goose on Windows (#5156) feat: add CI/CD Pipeline recipe (#5183)

continue from last user message

ba9bbb7

Extra ensure tokens check

c838613

Fmt

760002b

jamadeo self-requested a review October 15, 2025 19:05

handle autocompact errors

b8ede92

jamadeo approved these changes Oct 15, 2025

View reviewed changes

alexhancock approved these changes Oct 15, 2025

View reviewed changes

alexhancock and others added 4 commits October 15, 2025 16:45

fix: tests related to message metadata

4abe88e

fix double compact message

b79a1e4

Fix error message

9be9afc

Merge branch 'douwe-dkatz-alexhancock/compaction' of github.com:block…

a331e5f

…/goose into douwe-dkatz-alexhancock/compaction * 'douwe-dkatz-alexhancock/compaction' of github.com:block/goose: fix: tests related to message metadata

DOsinga marked this pull request as ready for review October 15, 2025 21:17

Douwe Osinga added 3 commits October 15, 2025 17:28

ignore

8cd3b3e

Rerecord

1335e3a

Clippy

2fdf4ba

DOsinga merged commit 7c1f5dc into main Oct 15, 2025
11 checks passed

DOsinga deleted the douwe-dkatz-alexhancock/compaction branch October 15, 2025 22:39

alexhancock mentioned this pull request Oct 17, 2025

Release/1.11.0 #5224

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compaction overhaul#5186

Compaction overhaul#5186
DOsinga merged 24 commits intomainfrom
douwe-dkatz-alexhancock/compaction

DOsinga commented Oct 15, 2025

Uh oh!

jamadeo left a comment

Uh oh!

jamadeo Oct 15, 2025

Uh oh!

jamadeo Oct 15, 2025

Uh oh!

jamadeo Oct 15, 2025

Uh oh!

jamadeo Oct 15, 2025

Uh oh!

DOsinga Oct 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

DOsinga commented Oct 15, 2025

Uh oh!

jamadeo left a comment

Choose a reason for hiding this comment

Uh oh!

jamadeo Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

jamadeo Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

jamadeo Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

jamadeo Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

DOsinga Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants